On Mon, May 09, 2016 at 01:59:51PM +0100, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <[email protected]>
> ---
>  libavcodec/mjpegdec.c | 52 
> +++++++++++++++++++++++++++------------------------
>  1 file changed, 28 insertions(+), 24 deletions(-)

LGTM

> --- a/libavcodec/mjpegdec.c
> +++ b/libavcodec/mjpegdec.c
> @@ -1525,8 +1526,11 @@ int ff_mjpeg_decode_frame(AVCodecContext *avctx, void 
> *data, int *got_frame,
>          else if (start_code >= APP0 && start_code <= APP15)
>              mjpeg_decode_app(s);
>              /* Comment */
> -        else if (start_code == COM)
> -            mjpeg_decode_com(s);
> +        else if (start_code == COM) {
> +            ret = mjpeg_decode_com(s);
> +            if (ret < 0)
> +                return ret;
> +        }

mjpeg_decode_app also returns errors that are simply discarded.  Why did
I even bother looking at the file..?  I'll fix it once this is in...

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to