On 09/06/16 08:10, Anton Khirnov wrote:
> Quoting Mark Thompson (2016-06-01 00:29:19)
>> Supports aspect ratio, colour format and timing information.
>> ---
>>  libavcodec/vaapi_encode_h264.c | 126 
>> ++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 124 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
>> index 2341b12..139e6e9 100644
>> --- a/libavcodec/vaapi_encode_h264.c
>> +++ b/libavcodec/vaapi_encode_h264.c
>> @@ -61,7 +61,29 @@ typedef struct VAAPIEncodeH264MiscSequenceParams {
>>
>>      int pic_init_qs_minus26;
>>
>> -    char vui_parameters_present_flag;
>> +    char overscan_info_present_flag;
> 
> Perhaps uint8_t would be more appropriate to show you really want a
> 'small int' and not an actual character.

I don't want a small int, I want a bool :P

Flags are consistently char throughout, with (possibly-unsigned) int for
anything taking more than two values, so I think I will leave it.

> Looks good otherwise.

Thanks.

- Mark

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to