On Fri, Jun 17, 2016 at 10:20 AM, Diego Biurrun <[email protected]> wrote:
> On Mon, Jun 06, 2016 at 12:31:56PM -0400, Vittorio Giovara wrote:
>> --- a/doc/general.texi
>> +++ b/doc/general.texi
>> @@ -672,6 +672,7 @@ following image formats are supported:
>> @item lossless MJPEG @tab X @tab X
>> +@item MagicYUV Lossless Video @tab @tab X
>> @item Microsoft ATC Screen @tab @tab X
>> --- a/libavcodec/codec_desc.c
>> +++ b/libavcodec/codec_desc.c
>> @@ -1191,6 +1191,13 @@ static const AVCodecDescriptor codec_descriptors[] = {
>> + .id = AV_CODEC_ID_MAGICYUV,
>> + .type = AVMEDIA_TYPE_VIDEO,
>> + .name = "magicyuv",
>> + .long_name = NULL_IF_CONFIG_SMALL("MagicYUV Lossless Video"),
>> --- /dev/null
>> +++ b/libavcodec/magicyuv.c
>> @@ -0,0 +1,469 @@
>> +AVCodec ff_magicyuv_decoder = {
>> + .name = "magicyuv",
>> + .long_name = NULL_IF_CONFIG_SMALL("MagicYUV Lossless Video"),
>> + .type = AVMEDIA_TYPE_VIDEO,
>
> Is the capitalized "Lossless Video" part of the name? Otherwise it's a
> tad odd.
renamed to MagicYUV video
>> --- /dev/null
>> +++ b/libavcodec/magicyuv.c
>> @@ -0,0 +1,469 @@
>> +
>> +static int magy_decode_slice(AVCodecContext *avctx, void *tdata,
>> + int j, int threadnr)
>> +{
>> + int fake_stride = p->linesize[i] * (1 + interlaced);
>> + int stride = p->linesize[i];
>
> Strides should be ptrdiff_t; not sure here when frame.linesize is int
> already.
I changed it anyway.
>> + for (i = 0; i < s->planes; i++) {
>> + av_fast_malloc(&s->slices[i], (unsigned *)&s->slices_size[i],
>> s->nb_slices * sizeof(Slice));
>
> Do you need the cast?
yeah, av_fast_malloc needs unsigned int * there, and this element type
was changed to size_t in the previous iteration.
--
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
