Quoting Mark Thompson (2016-06-22 00:26:49) > The driver being used is detected inside av_hwdevice_ctx_init(), and > the quirks field then set from a table of known drivers. > > Also adds the Intel i965 driver quirk (it does not destroy parameter > buffers used in a call to vaRenderPicture()) and detects that driver > to set it. > --- > Not-quite-as-long name is not-quite-as-long. > > Do we want an explicit way to disable the autodetection and let the > user set the quirks field? Currently it works for the user to just > overwrite it after calling av_hwdevice_ctx_init().
Setting it after init feels a bit unclean to me, since the intent was for the device context to be constant after init (to avoid synchronization issues). It's not a problem in practice though, if the caller does it right after. So I'll leave the decision up to you, it probably does not matter much either way. Patch looks fine to me, assuming you add an APIchanges entry and a minor bump on push. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
