On 25/06/16 11:00, Anton Khirnov wrote:
> Quoting Mark Thompson (2016-06-23 01:12:14)
>> On 21/06/16 18:50, Anton Khirnov wrote:
>>> This will be useful in the following commit, after which the muxer
>>> timebase is not always available when encoding.
>>> ---
>>>  avconv.c | 23 ++++++++++++-----------
>>>  avconv.h |  2 ++
>>>  2 files changed, 14 insertions(+), 11 deletions(-)
>>> ...
>>> @@ -314,7 +314,7 @@ static void write_packet(OutputFile *of, AVPacket *pkt, 
>>> OutputStream *ost)
>>>  
>>>          if (ost->frame_rate.num) {
>>>              pkt->duration = av_rescale_q(1, av_inv_q(ost->frame_rate),
>>> -                                         ost->st->time_base);
>>> +                                         ost->mux_timebase);
>>
>> I think this one wants to stay as-is?
> 
> It makes no difference, since they are equal, but I think it's more
> consistent to use ost->mux_timebase.

Apologies, my comment was just wrong - I was going for the same time-base as 
the packet rescale below, but missed that av_packet_rescale_ts() deals with the 
duration as well.  What you have is right.

- Mark

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to