Quoting Diego Biurrun (2016-06-27 16:22:40) > --- > libavcodec/Makefile | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index f86ccb8..ef7f35e 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -640,28 +640,13 @@ OBJS-$(CONFIG_ISO_MEDIA) += mpeg4audio.o > mpegaudiodata.o > > OBJS-$(CONFIG_ADTS_MUXER) += mpeg4audio.o > OBJS-$(CONFIG_CAF_DEMUXER) += ac3tab.o > -OBJS-$(CONFIG_FLAC_MUXER) += flac.o flacdata.o > OBJS-$(CONFIG_FLV_DEMUXER) += mpeg4audio.o > -OBJS-$(CONFIG_GXF_DEMUXER) += mpeg12data.o > -OBJS-$(CONFIG_IFF_DEMUXER) += iff.o > OBJS-$(CONFIG_LATM_MUXER) += mpeg4audio.o > -OBJS-$(CONFIG_MATROSKA_AUDIO_MUXER) += mpeg4audio.o \
This just makes the dependency indirect and so less clear. The mka muxer depends on isomedia, which also depends on mpeg4audio. Since the mka muxer also depends on mpeg4audio directly (it uses avpriv_mpeg4audio_get_config), I do not think this should be done. > - flac.o flacdata.o > -OBJS-$(CONFIG_MATROSKA_MUXER) += flac.o flacdata.o > OBJS-$(CONFIG_MOV_DEMUXER) += ac3tab.o > -OBJS-$(CONFIG_MP2_MUXER) += mpegaudiodata.o > mpegaudiodecheader.o This looks ok in principle, but the mp2 muxer is defined in the same file as mp3, even though it does not use any of its functions. Those functions (which do depend on this mpegaudio stuff) are compiled unconditionally, so IIUC it depends on the compiler DCEing away all this unused code. > OBJS-$(CONFIG_MP3_MUXER) += mpegaudiodata.o > mpegaudiodecheader.o > -OBJS-$(CONFIG_MPEGTS_MUXER) += mpeg4audio.o > OBJS-$(CONFIG_NUT_MUXER) += mpegaudiodata.o > -OBJS-$(CONFIG_OGG_DEMUXER) += mpeg12data.o \ > - dirac.o > -OBJS-$(CONFIG_OGG_MUXER) += flac.o flacdata.o > -OBJS-$(CONFIG_RTP_MUXER) += mpeg4audio.o > OBJS-$(CONFIG_SPDIF_DEMUXER) += aacadtsdec.o mpeg4audio.o > OBJS-$(CONFIG_SPDIF_MUXER) += dca.o > -OBJS-$(CONFIG_TAK_DEMUXER) += tak.o Again, this creates a hidden indirect dependency: the TAK demuxer uses avpriv_tak_parse_streaminfo() from libavcodec/tak.c. That file will still be built, since the TAK demuxer selects the TAK parser, which also depends on tak.o. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
