On Sat, 9 Jul 2016, Janne Grunau wrote:

Fixes a checkasm segfault in vp8dsp.mc due to stack corruption in above
functions. llvm's internal assembler evaluates boolean expressions to 1
and not to -1 like GNU as. This avoids the boolean expression and
halves the stack usage for size 4 and 8 since the previous calculation
allocated more stack than necessary.

Hmm, are you sure about that?

For MSVC/gas-preprocessor builds, it still crashes when doing "make fate-vp8 CPUFLAGS=armv6" after this patch, but if changed into

#define TMPSIZE \size * (2*\size + \ytaps - 1)

it passes. I don't quite understand why a build with your patch unchanged succeeds in the same test in a gcc build though.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to