> IMO more compact: The code is nicely aligned now, I don't want it to be more compact > > INIT_MMX mmxext > IDCT_DC_NL 4, 8 > IDCT_DC_NL 4, 10 > IDCT_DC 8, 2, 8 > IDCT_DC 8, 2, 10 > > INIT_XMM sse2 > IDCT_DC_NL 8, 8 > IDCT_DC_NL 8, 10 > IDCT_DC 16, 4, 8 > IDCT_DC 16, 4, 10 > IDCT_DC 32, 16, 8 > IDCT_DC 32, 16, 10 > > %if HAVE_AVX2_EXTERNAL > INIT_YMM avx2 > IDCT_DC 16, 2, 8 > IDCT_DC 16, 2, 10 > IDCT_DC 32, 8, 8 > IDCT_DC 32, 8, 10 > %endif ;HAVE_AVX2_EXTERNAL >
> >> --- a/libavcodec/x86/hevcdsp_init.c >> +++ b/libavcodec/x86/hevcdsp_init.c >> @@ -45,6 +45,39 @@ LFC_FUNCS(uint8_t, 10) >> +#define idct_dc_proto(size, bitd, opt) \ >> + void ff_hevc_idct_ ## size ## _dc_add_ ## bitd ## _ ## >> opt(uint8_t *dst, int16_t *coeffs, ptrdiff_t stride) > > random 17 spaces indentation yes, I missed the broken indentation here > >> +idct_dc_proto(4, 8,mmxext); >> +idct_dc_proto(8, 8,mmxext); >> +idct_dc_proto(16,8, sse2); >> +idct_dc_proto(32,8, sse2); >> + >> +idct_dc_proto(32,8, avx2); > > spaces after ',' again, the code is nicely aligned and I'd prefer not to change it for no reason _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
