Quoting Diego Biurrun (2016-07-02 15:44:58) > On Thu, Jun 30, 2016 at 06:51:11PM +0200, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-06-09 17:12:02) > > > --- a/libavcodec/atrac1.c > > > +++ b/libavcodec/atrac1.c > > > @@ -195,22 +197,22 @@ static int at1_unpack_dequant(GetBitContext* gb, > > > AT1SUCtx* su, > > > /* calc number of consumed bits: > > > num_BFUs * (idwl(4bits) + idsf(6bits)) + log2_block_count(8bits) > > > + info_byte(8bits) > > > + info_byte_copy(8bits) + log2_block_count_copy(8bits) */ > > > bits_used = su->num_bfus * 10 + 32 + > > > - bfu_amount_tab2[get_bits(gb, 2)] + > > > - (bfu_amount_tab3[get_bits(gb, 3)] << 1); > > > + bfu_amount_tab2[bitstream_read(bc, 2)] + > > ^^ > > Broken indentation. > > > > Otherwise looks ok. > > That's some vertical alignment prettyprinting.
One of the expressions is inside the parens, the other outside, so vertically aligning them is misleading. Please do not do that. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
