On Sat, Jul 30, 2016 at 10:02:53PM +0200, Anton Khirnov wrote:
> --- a/tests/checkasm/Makefile
> +++ b/tests/checkasm/Makefile
> @@ -6,6 +6,7 @@ AVCODECOBJS-$(CONFIG_H264DSP)           += h264dsp.o
>  AVCODECOBJS-$(CONFIG_H264PRED)          += h264pred.o
>  AVCODECOBJS-$(CONFIG_H264QPEL)          += h264qpel.o
>  AVCODECOBJS-$(CONFIG_VP8DSP)            += vp8dsp.o
> +AVCODECOBJS-$(CONFIG_VP9_DECODER)       += vp9dsp.o

Group this with decoders/encoders below.

> --- /dev/null
> +++ b/tests/checkasm/vp9dsp.c
> @@ -0,0 +1,127 @@
> +
> +#include <string.h>
> +
> +#include "checkasm.h"
> +
> +#include "libavcodec/vp9.h"
> +
> +#include "libavutil/common.h"
> +#include "libavutil/internal.h"
> +#include "libavutil/intreadwrite.h"

The order is reversed, it should be libavutil, libavcodec, then
checkasm.h.

> +            for (filter = 0; filter < 4; filter++) {
> +                for (dx = 0; dx < 2; dx++) {
> +                    for (dy = 0; dy < 2; dy++) {
> +                        if (dx || dy) {
> +                            snprintf(str, sizeof(str), "%s_%s_%d%s", 
> op_names[op],
> +                                    filter_names[filter], size,
> +                                    subpel_names[dy][dx]);

Indentation is off.

> +                            // simd implementations for each filter of subpel

nit: SIMD

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to