Quoting Timothy Gu (2016-08-04 00:00:53) > On Wed, Aug 3, 2016 at 12:54 AM Anton Khirnov <[email protected]> wrote: > > > A non-existent av_buffer_pool_can_uninit() function is mentioned instead > > of av_buffer_pool_uninit(). Also, this function is to be called by the > > caller, not the pool itself. > > --- > > libavutil/buffer.h | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/libavutil/buffer.h b/libavutil/buffer.h > > index 46779ca..58def6f 100644 > > --- a/libavutil/buffer.h > > +++ b/libavutil/buffer.h > > @@ -249,9 +249,10 @@ AVBufferPool *av_buffer_pool_init(int size, > > AVBufferRef* (*alloc)(int size)); > > * @param alloc a function that will be used to allocate new buffers when > > the > > * pool is empty. > > * @param pool_free a function that will be called immediately before the > > pool > > - * is freed. I.e. after av_buffer_pool_can_uninit() is > > called > > - * by the pool and all the frames are returned to the > > pool and > > - * freed. It is intended to uninitialize the user opaque > > data. > > + * is freed. I.e. after av_buffer_pool_uninit() is called > > + * by the caller and all the frames are returned to the > > pool > > > > "by the caller" sounds a bit redundant. > > Perhaps also make it clear that this function is called *by* > av_buffer_pool_uninit(), not *after*?
Well, that's not necessarily true. av_buffer_pool_uninit() will only unref the caller's reference to the pool, but the pool itself will still stay around if any buffers allocated from it are still active. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
