On Thu, Aug 25, 2016 at 11:49:05PM -0500, Burt P. wrote: > On Thu, Aug 25, 2016 at 7:42 PM, James Almer <[email protected]> wrote: > > On 8/25/2016 6:53 PM, Burt P. wrote: > >> On Thu, Aug 25, 2016 at 8:56 AM, Diego Biurrun <[email protected]> wrote: > >>> The _t namespace is reserved for POSIX, the library should not invade it. > >> > >> Um, I think it is too late to change it. > > > > Seeing this is kinda important, i think it's a good reason to make the > > change even if you already made a release. > > The library is currently used by nothing, so you can safely bump the > > soname version and make sure to tag release 0.1 as a bad/buggy one. > > > > Pity it wasn't pointed in the first patch you sent, though. > > >>> Why does the library use an shdcd instead of an hdcd prefix? > >> > >> It is the "simple" api of the library. Maybe it should have been > >> hdcds_ or something, but it isn't. > > > > You can change this alongside the above. > > I can remove _t from types easily, but does the shdcd_* -> hdcds_* > really need to happen? > Is there a rule somewhere about this?
It's called the rule of least surprise. A function name prefix should be related to the name of the library or the format. Adding seemingly random characters is just a source for confusion. What simple API is this? Do you offer a complicated API also? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
