On Fri, Sep 09, 2016 at 08:08:55PM +0200, Janne Grunau wrote: > On 2016-09-05 20:31:39 +0200, Diego Biurrun wrote: > > Previously all external library dependencies were added as link-time > > dependencies to all components. This adds bogus dependencies to some > > components, so only add dependencies to components if said components > > actually make use of a dependency. > > --- > > > > This can still be improved a bit I guess. Better function names welcome for > > starters. Janne had some more substantive comments. Our pkg-config files > > have > > many more issues, even after this patch... > > I don't think this is the right approach. The fundamental problem in > this patch is that it mixes the checks functions/libraries with the > information which part of libav uses the library. The basic idea would > be to set fn_$(func)_extralibs in check_lib(2) and have components > depend fn_$(func). We can't check for multiple functions in > check_lib(2) after that at once but we don't do it atm.
You have me slightly confused with fn and func to be honest. Can you clarify what you mean please? > The dep_extralibs handling in check_deps() needs to be modified (looks > like it is missing in this patch). Yes, I forgot to mention that the patch is incomplete in that regard. It's still an RFC and we need to settle which general direction this patch should take first. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
