Quoting Alexandra Hájková (2016-09-18 19:35:25)
> ---
>  libavcodec/x86/hevc_idct.asm  | 710 
> ++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/x86/hevcdsp_init.c |  21 ++
>  2 files changed, 731 insertions(+)
> 
> diff --git a/libavcodec/x86/hevc_idct.asm b/libavcodec/x86/hevc_idct.asm
> index d662aa9..848812b 100644
> --- a/libavcodec/x86/hevc_idct.asm
> +++ b/libavcodec/x86/hevc_idct.asm
> +
>  ; 8-bit
>  INIT_MMX mmxext
>  IDCT_DC_NL  4,      8
> @@ -84,6 +782,12 @@ IDCT_DC_NL  8,      8
>  IDCT_DC    16,  4,  8
>  IDCT_DC    32, 16,  8
>  
> +INIT_XMM avx
> +IDCT_4x4 8
> +IDCT_8x8 8
> +IDCT_16x16 8
> +IDCT_32x32 8
> +
>  %if HAVE_AVX2_EXTERNAL
>  INIT_YMM avx2
>  IDCT_DC    16,  2,  8
> @@ -100,6 +804,12 @@ IDCT_DC_NL  8,     10
>  IDCT_DC    16,  4, 10
>  IDCT_DC    32, 16, 10
>  
> +INIT_XMM avx
> +IDCT_4x4 10
> +IDCT_8x8 10
> +IDCT_16x16 10
> +IDCT_32x32 10

It seems rather silly to duplicate all those functions when the only
difference between them is the value of a constant. Perhaps it'd be
better to change that into a parameter.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to