Quoting Vittorio Giovara (2016-09-21 15:43:33)
> On Wed, Sep 21, 2016 at 2:56 AM, Anton Khirnov <an...@khirnov.net> wrote:
> > Quoting Vittorio Giovara (2016-09-20 23:12:02)
> >> On Tue, Sep 20, 2016 at 3:07 PM, Anton Khirnov <an...@khirnov.net> wrote:
> >> > typo in the commite message
> >> >
> >> > Quoting Vittorio Giovara (2016-09-19 22:33:43)
> >> >> From: Carl Eugen Hoyos <ceho...@ag.or.at>
> >> >>
> >> >> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com>
> >> >> ---
> >> >>  libavcodec/rscc.c | 21 ++++++++++++++++++---
> >> >>  1 file changed, 18 insertions(+), 3 deletions(-)
> >> >>
> >> >> diff --git a/libavcodec/rscc.c b/libavcodec/rscc.c
> >> >> index 4a91783..91ffae2 100644
> >> >> --- a/libavcodec/rscc.c
> >> >> +++ b/libavcodec/rscc.c
> >> >> @@ -31,7 +31,7 @@
> >> >>   * and it can be deflated or not. Similarly, pixel data comes after 
> >> >> the header
> >> >>   * and a variable size value, and it can be deflated or just raw.
> >> >>   *
> >> >> - * Supports: BGRA, BGR24, RGB555, RGB8
> >> >> + * Supports: PAL8, BGRA, BGR24, RGB555, RGB8
> >> >>   */
> >> >>
> >> >>  #include <stdint.h>
> >> >> @@ -59,6 +59,8 @@ typedef struct RsccContext {
> >> >>      unsigned int tiles_size;
> >> >>      int component_size;
> >> >>
> >> >> +    uint8_t palette[AVPALETTE_SIZE];
> >> >
> >> > What is this for?
> >>
> >> I think to track palette change under /* Palette handling */
> >
> > But it's not actually used in that block from what I can see.
> 
> Umh? It's used here:
> 
> +        if (palette) {
> +            frame->palette_has_changed = 1;
> +            memcpy(ctx->palette, palette, AVPALETTE_SIZE);
> +        }
> +        memcpy (frame->data[1], ctx->palette, AVPALETTE_SIZE);

That is a different variable.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to