On Wed, Oct 12, 2016 at 06:24:39PM +0200, Alexandra Hájková wrote:
> --- /dev/null
> +++ b/libavcodec/x86/hevc_res_add.asm
> @@ -0,0 +1,391 @@
> +; /*

Drop the /, this is not C.

> +; * Provide SIMD optimizations for add_residual functions for HEVC decoding

s/Provide//

> +; * Copyright (c) 2014 Pierre-Edouard LEPERE
> +; *
> +; * This file is part of Libav.
> +; *
> +; * FFmpeg is free software; you can redistribute it and/or

This is not FFmpeg.

> +; * modify it under the terms of the GNU Lesser General Public
> +; * License as published by the Free Software Foundation; either
> +; * version 2.1 of the License, or (at your option) any later version.
> +; *
> +; * FFmpeg is distributed in the hope that it will be useful,
> +; * but WITHOUT ANY WARRANTY; without even the implied warranty of
> +; * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +; * Lesser General Public License for more details.
> +; *
> +; * You should have received a copy of the GNU Lesser General Public
> +; * License along with FFmpeg; if not, write to the Free Software
> +; * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
> +; */
> +%include "libavutil/x86/x86util.asm"

Drop the / and add an empty line.

> +;-----------------------------------------------------------------------------
> +; void ff_hevc_add_residual__10(pixel *dst, int16_t *block, int stride)
> +;-----------------------------------------------------------------------------
> +%macro ADD_RES_SSE_8_10 4

I don't think this function uses an int stride, stray double underscore.

> +;-----------------------------------------------------------------------------
> +; void ff_hevc_add_residual__10(pixel *dst, int16_t *block, int stride)
> +;-----------------------------------------------------------------------------

same

> +%if HAVE_AVX2_EXTERNAL
> +INIT_YMM avx2
> +
> +cglobal hevc_add_residual_16_10,3,5,6
> +%endif ;HAVE_AVX_EXTERNAL

The %if and the %endif comment do not match.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to