On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote:
> On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote:
> > --- /dev/null
> > +++ b/tests/fate/mov.mak
> > @@ -0,0 +1,12 @@
> > +FATE_MOV += fate-mov-display-matrix
> > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix 
> > $(TARGET_SAMPLES)/mov/displaymatrix.mov
> > +
> > +FATE_MOV += fate-mov-rotation
> > +fate-mov-rotation: CMD = run avprobe -v 0 -show_stream_entry rotation 
> > $(TARGET_SAMPLES)/mov/displaymatrix.mov
> > +
> > +FATE_MOV += fate-mov-ar
> > +fate-mov-ar: CMD = probear $(TARGET_SAMPLES)/mov/displaymatrix.mov
> > +
> > +$(FATE_MOV): avprobe$(EXESUF)
> > +FATE_SAMPLES-$(call ALLYES, AVPROBE, MOV_DEMUXER) += $(FATE_MOV)
> 
> ALLYES does not work this way, the second ',' is wrong.
> 
> IMO this should go in probe.mak. That would also fix the deps, you are
> missing at least a dependency on the avprobe program.

I'm blind today, you have the dependency of course. probe.mak still looks
like a better place to me.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to