On Fri, Nov 11, 2016 at 09:36:26AM -0500, Vittorio Giovara wrote:
> On Fri, Nov 11, 2016 at 8:45 AM, Diego Biurrun <[email protected]> wrote:
> > The version is not checked for and multiple words in the name parameter
> > of require() calls can cause side effects down the call chain.
> > --- a/configure
> > +++ b/configure
> > @@ -4631,9 +4631,9 @@ enabled libgsm            && { for gsm_hdr in "gsm.h" 
> > "gsm/gsm.h"; do
> >                                 done || die "ERROR: libgsm not found"; }
> >  enabled libhdcd           && require_pkg_config libhdcd 
> > "hdcd/hdcd_simple.h" hdcd_new
> >  enabled libilbc           && require libilbc ilbc.h 
> > WebRtcIlbcfix_InitDecode -lilbc
> > -enabled libkvazaar        && require_pkg_config "kvazaar >= 0.8.1" 
> > kvazaar.h kvz_api_get
> > +enabled libkvazaar        && require_pkg_config kvazaar kvazaar.h 
> > kvz_api_get
> 
> libkvazaar does not compile with previous versions though, how can one
> make sure of that?

By crafting a proper test that actually tests for the library version.
That "condition" that I am removing does not get checked, it merely
gets printed as part of the library name.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to