Quoting Diego Biurrun (2016-11-14 10:03:43) > On Mon, Nov 14, 2016 at 09:20:12AM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-14 09:05:33) > > > Fixes a number of warnings of the type > > > libavutil/hmac.c:61:21: warning: assignment from incompatible pointer type > > > > No, this does not "fix" anything. It hides real warnings caused by real > > problems. I really wish you stopped fixing warnings and perhaps fixed > > the bugs that cause those warnings instead. > > Interestingly, this patch is from Kostya. I'm open to your suggestion > of the "real fix".
What does it matter who is it from? It is wrong. The compiler prints a warning because you're calling a function using a wrong signature (signed int vs unsigned). Strictly speaking, this is UB. The only thing this patch does is shut up the warning, but the problem is still there - you are still calling a function using a wrong signature. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
