On Mon, Nov 21, 2016 at 8:52 AM, Diego Biurrun <[email protected]> wrote: > --- > libavcodec/dvbsubdec.c | 2 -- > libavcodec/dvdsubdec.c | 1 - > libavcodec/pgssubdec.c | 1 - > libavutil/colorspace.h | 2 ++ > 4 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c > index 0ca8f7e..678824b 100644 > --- a/libavcodec/dvbsubdec.c > +++ b/libavcodec/dvbsubdec.c > @@ -32,8 +32,6 @@ > #define DVBSUB_DISPLAYDEFINITION_SEGMENT 0x14 > #define DVBSUB_DISPLAY_SEGMENT 0x80 > > -#define cm (ff_crop_tab + MAX_NEG_CROP) > - > #ifdef DEBUG > static void png_save(const char *filename, uint32_t *bitmap, int w, int h) > { > diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c > index c6673bf..d1c536a 100644 > --- a/libavcodec/dvdsubdec.c > +++ b/libavcodec/dvdsubdec.c > @@ -35,7 +35,6 @@ typedef struct DVDSubContext { > > static void yuv_a_to_rgba(const uint8_t *ycbcr, const uint8_t *alpha, > uint32_t *rgba, int num_values) > { > - const uint8_t *cm = ff_crop_tab + MAX_NEG_CROP; > uint8_t r, g, b; > int i, y, cb, cr; > int r_add, g_add, b_add; > diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c > index 886685b..ec89aae 100644 > --- a/libavcodec/pgssubdec.c > +++ b/libavcodec/pgssubdec.c > @@ -324,7 +324,6 @@ static int parse_palette_segment(AVCodecContext *avctx, > PGSSubPalette *palette; > > const uint8_t *buf_end = buf + buf_size; > - const uint8_t *cm = ff_crop_tab + MAX_NEG_CROP; > int color_id; > int y, cb, cr, alpha; > int r, g, b, r_add, g_add, b_add; > diff --git a/libavutil/colorspace.h b/libavutil/colorspace.h > index cc27f38..31b780a 100644 > --- a/libavutil/colorspace.h > +++ b/libavutil/colorspace.h > @@ -27,6 +27,8 @@ > #ifndef AVUTIL_COLORSPACE_H > #define AVUTIL_COLORSPACE_H > > +#define cm (ff_crop_tab + MAX_NEG_CROP)
Wait ff_crop_tab is a table defined in libavcodec right? It doesn't seem right to reference it here. Also there are a bunch of other places where this could be replaced. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
