On Wed, Nov 23, 2016 at 11:35:08PM +0200, Martin Storsjö wrote:
> The rtmpdh code can use crypto libraries which may require
> a process global init. (gcrypt is one of the libraries
> where the rtmpdh test code can fail if global init hasn't been
> done, depending on gcrypt version.)
> ---
> libavformat/tests/rtmpdh.c | 2 ++
> 1 file changed, 2 insertions(+)
As you predicted, this does not fail my particular test case.
> --- a/libavformat/tests/rtmpdh.c
> +++ b/libavformat/tests/rtmpdh.c
> @@ -17,6 +17,7 @@
>
> #include "libavformat/rtmpdh.c"
> +#include "libavformat/avformat.h"
nit: order
> @@ -150,6 +151,7 @@ fail:
>
> int main(void)
> {
> + avformat_network_init();
> if (test_random_shared_secret() < 0)
> return 1;
> if (test_ref_data() < 0)
LGTM
Please push to the 12 branch as well.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
