Quoting James Almer (2016-11-25 03:02:30) > On 3/19/2016 1:02 PM, Anton Khirnov wrote: > > Quoting Luca Barbato (2016-03-07 09:10:14) > >> On 07/03/16 08:59, Luca Barbato wrote: > >>> On 04/03/16 09:15, Anton Khirnov wrote: > >>>> --- > >>>> libavcodec/aac_adtstoasc_bsf.c | 95 > >>>> ++++++++++++++++++++++++++---------------- > >>>> libavcodec/allcodecs.c | 1 - > >>>> libavcodec/bitstream_filters.c | 5 +++ > >>>> 3 files changed, 65 insertions(+), 36 deletions(-) > >>>> > >>> > >>> Possibly Ok. > >>> > >> > >> Reading the others, why the par_out->extradata is not set? > > > > Because it's set as side data in the first packet. Actually it should be > > actively unset from the output parameters. > > This is not what should be done. If the stream has extradata during .init() > then it means it's ASC and not ADTS or even LATM. Deleting it unconditionally > breaks passthrough use cases. > > The .init function should validate the extradata and let av_bsf_init() pass > it down the filter chain. See the attached patch.
Looks sensible. Queuing, thanks. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
