On Thu, Dec 01, 2016 at 02:13:00AM -0500, Vittorio Giovara wrote:
> On Thu, Dec 1, 2016 at 1:37 AM, Diego Biurrun <[email protected]> wrote:
> > On Wed, Nov 30, 2016 at 06:28:29PM -0500, Vittorio Giovara wrote:
> >> --- a/tests/fate/mov.mak
> >> +++ b/tests/fate/mov.mak
> >> @@ -10,6 +10,16 @@ fate-mov-rotation: CMD = probestream rotation 
> >> $(TARGET_SAMPLES)/mov/displaymatri
> >>
> >> +FATE_MOV += fate-mov-spherical
> >> +fate-mov-spherical: \
> >> +    CMD = probestream projection $(TARGET_SAMPLES)/mov/spherical.mov && \
> >> +          probestream yaw $(TARGET_SAMPLES)/mov/spherical.mov && \
> >> +          probestream pitch $(TARGET_SAMPLES)/mov/spherical.mov && \
> >> +          probestream roll $(TARGET_SAMPLES)/mov/spherical.mov
> >
> > These should be separate tests. They can then run in parallel and fail
> > separately.
> 
> I don't think so, this tests everything currently exported by the side
> data, there is no point in splitting the test. Also it would parse the
> same thing 4 times, which is simply wasteful, in my opinion.

It runs 4 different commands, it should be 4 tests. Also, we live in a
parallel world, hence 4 tests will run 4 times as fast.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to