On Thu, Dec 01, 2016 at 01:12:45PM +0100, Diego Biurrun wrote: > On Thu, Dec 01, 2016 at 01:05:18PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-30 21:49:26) > > > On Tue, Nov 29, 2016 at 03:29:17PM -0500, Vittorio Giovara wrote: > > > > On Tue, Nov 29, 2016 at 1:34 PM, Diego Biurrun <[email protected]> wrote: > > > > > --- a/libavdevice/libdc1394.c > > > > > +++ b/libavdevice/libdc1394.c > > > > > @@ -104,9 +79,6 @@ struct dc1394_frame_rate { > > > > > #define OFFSET(x) offsetof(dc1394_data, x) > > > > > #define DEC AV_OPT_FLAG_DECODING_PARAM > > > > > static const AVOption options[] = { > > > > > -#if HAVE_LIBDC1394_1 > > > > > - { "channel", "", offsetof(dc1394_data, channel), > > > > > AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, > > > > > -#endif > > > > > > > > should this option be kept around and converted into a warning, so not > > > > to break random scripts still in the wild? > > > > > > That's a question for Anton, he added that option back in 2011. > > > > Well, I only added it to replace the stuff in AVFormatParameters. But > > for what my opinion here is worth (never used this device), if this > > option is just for the obsolete library version then it didn't even > > exist for any modern builds. So there should be no problem with just > > dropping it. > > The way of the dodo it shall go then...
Does this warrant a changelog entry? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
