LGTM
On Wed, Dec 14, 2016 at 9:22 AM, Martin Storsjö <[email protected]> wrote: > On Tue, 13 Dec 2016, Steve Lhomme wrote: > >> From: Steve Lhomme <[email protected]> >> >> Otherwise some ARM and other unsupported CPU/OS is linked with -O0 >> --- >> configure | 1 + >> 1 file changed, 1 insertion(+) > > > I find the commit message quite hard to understand and easily misleading. > Would this make more sense? > > ---8<--- > configure: Use -O1 with MSVC for --disable-optimizations > > Without any optimization flags, MSVC does no dead code elimination (DCE) at > all, even for the most trivial cases. DCE is a prerequisite for building > libav correctly, otherwise there are undefined references to functions for > other architectures and disabled components. > > -O1 is the minimal optimization flags for MSVC that does include DCE. > ---8<--- > > // Martin > > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
