Quoting Wan-Teh Chang (2016-12-09 18:54:47) > This improves commit 59c70227405c214b29971e6272f3a3ff6fcce3d0. > > In ff_thread_report_progress(), the fast code path can load > progress[field] with the relaxed memory order, and the slow code path > can store progress[field] with the release memory order. These changes > are mainly intended to avoid confusion when one inspects the source code. > They are unlikely to have measurable performance improvement. > > ff_thread_report_progress() and ff_thread_await_progress() form a pair. > ff_thread_await_progress() reads progress[field] with the acquire memory > order (in the fast code path). Therefore, one expects to see > ff_thread_report_progress() write progress[field] with the matching > release memory order. > > In the fast code path in ff_thread_report_progress(), the atomic load of > progress[field] doesn't need the acquire memory order because the > calling thread is trying to make the data it just decoded visible to the > other threads, rather than trying to read the data decoded by other > threads. > > In ff_thread_get_buffer(), initialize progress[0] and progress[1] using > atomic_init(). > > Signed-off-by: Wan-Teh Chang <[email protected]> > --- > libavcodec/pthread_frame.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
Pushed, thanks. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
