On Wed, Dec 14, 2016 at 6:06 PM, Diego Biurrun <[email protected]> wrote: > On Wed, Dec 14, 2016 at 05:22:52PM +0100, Hendrik Leppkes wrote: >> On Wed, Dec 14, 2016 at 5:15 PM, Diego Biurrun <[email protected]> wrote: >> > -O2 is the highest warning level understood by MSVC, higher warning >> > levels produce warnings. >> >> s/warning/optimization/ ? > > Indeed, thanks. > >> > --- a/configure >> > +++ b/configure >> > @@ -3214,6 +3214,7 @@ msvc_common_flags(){ >> > # Common flags >> > -fomit-frame-pointer) ;; >> > -g) echo -Z7 ;; >> > + -O[3-9]) echo -O2 ;; >> > -fno-math-errno) ;; >> > -fno-common) ;; >> > -fno-signed-zeros) ;; >> >> We typically define the O flags per compiler already, so configure >> itself would never pass anything unsupported, and anyone passing >> custom cflags should know what he is passing them to, so I'm not sure >> what you are actually trying to solve here, tbh. > > We're not quite as smart as you hope for the host: > > check_host_cflags -O3 > > Possibly a different solution is better, like no optimizations for hostcc or > size optimizations for hostcc, but this patch is certainly an option. >
probe_cc, which sets what I was talking about, also runs for the host, so we could easily use that instead of some hardcoded value. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
