On Tue, Dec 20, 2016 at 5:54 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Tue, Dec 20, 2016 at 5:48 PM, Vittorio Giovara >> >> No, as I said I can compromise in simply moving "undefined" state to >> value 2, so that if there is a remote case where this is useful it can >> be still achieved. If that would be ok I'll send another patch. > > Seems equally pointless. And using an enum straight as a boolean is > the actual error prone thing, since you brought that up. > I don't see the advantage in using "if (range)" over "if (range == > AVCOL_RANGE_JPEG)", if anything the second is much clearer to what it > means.
I really disagree but since I'm clearly in the minority I'll withdraw this patch. > Personally I would introduce aliases for those names tho, > mpeg/jpeg seems a bit uncommon to me. I would be ok with it, will you send a patch? :) -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
