On Tue, Dec 27, 2016 at 02:44:08PM +0100, Anton Khirnov wrote:
> Quoting Diego Biurrun (2016-12-27 13:18:21)
> > On Sun, Dec 25, 2016 at 06:30:45PM +0100, Diego Biurrun wrote:
> > > --- a/avbuild/pkgconfig_generate.sh
> > > +++ b/avbuild/pkgconfig_generate.sh
> > > @@ -12,7 +12,15 @@ shortname=$1
> > > comment=$2
> > > libs=$(eval echo \$extralibs_${shortname})
> > > -requires=$(eval echo \$requires_${shortname})
> > > +deps=$(eval echo \$${shortname}_deps)
> > > +
> > > +for dep in $deps; do
> > > + depname=lib${dep}
> > > + . ${depname}/${depname}.version
> > > + depversion=$(eval echo \$${depname}_VERSION_MAJOR)
> > > + requires="$requires ${depname} >= ${depversion}, "
> > > +done
> >
> > Notice that this adds dependencies on "libfoo_VERSION_MAJOR >= X" instead
> > of "libfoo_VERSION_MAJOR >= X.Y.Z" as it did before. Adding random
> > (depending
> > on when configure was run) deps on minor and micro lib versions is incorrect
> > AFAICT. If somebody has a different opinion, now is the time to speak up.
>
> That sounds wrong to me. Dynamically linking against an earlier minor
> version than the one we built against is likely to fail. The previous
> behaviour is more correct IMO.
Pushed with that changed.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
