Quoting Diego Biurrun (2017-01-10 12:58:04) > On Tue, Jan 10, 2017 at 11:12:09AM +0100, Anton Khirnov wrote: > > --- > > configure | 2 +- > > libavcodec/aaccoder.c | 4 ++-- > > libavcodec/aacenc.c | 4 ++-- > > libavcodec/aacenc.h | 4 ++-- > > libavcodec/aic.c | 2 +- > > libavcodec/amrnbdata.h | 4 ++-- > > libavcodec/amrwbdata.h | 4 ++-- > > libavcodec/atrac3plus.c | 38 +++++++++++++++++++------------------- > > libavcodec/dfa.c | 2 +- > > libavcodec/g722dec.c | 6 +++--- > > libavcodec/h263data.c | 4 ++-- > > libavcodec/h263data.h | 4 ++-- > > libavcodec/indeo3.c | 4 ++-- > > libavcodec/indeo4data.h | 2 +- > > libavcodec/mpeg4videodec.c | 2 +- > > libavcodec/on2avc.c | 4 ++-- > > libavcodec/on2avcdata.c | 20 ++++++++++---------- > > libavcodec/on2avcdata.h | 20 ++++++++++---------- > > libavcodec/opus_silk.c | 6 +++--- > > libavcodec/qsvdec_h2645.c | 4 ++-- > > libavcodec/qsvenc_hevc.c | 4 ++-- > > libavcodec/sipr.c | 2 +- > > libavcodec/sipr16k.c | 2 +- > > libavcodec/sipr16kdata.h | 2 +- > > libavcodec/siprdata.h | 2 +- > > libavcodec/tscc2data.h | 6 +++--- > > libavcodec/vaapi_encode.c | 2 +- > > libavcodec/vaapi_encode_mjpeg.c | 2 +- > > libavcodec/vp8.c | 8 ++++---- > > libavcodec/vp9block.c | 4 ++-- > > libavcodec/vp9data.c | 4 ++-- > > libavcodec/vp9data.h | 4 ++-- > > libavcodec/x86/fdct.c | 4 ++-- > > libavcodec/x86/mlpdsp.c | 16 ++++++++-------- > > libavcodec/x86/videodsp_init.c | 12 ++++++------ > > libavfilter/af_volume.c | 2 +- > > libavfilter/vf_drawtext.c | 2 +- > > libavfilter/vf_libopencv.c | 4 ++-- > > libavfilter/vf_overlay.c | 2 +- > > libavformat/hls.c | 4 ++-- > > libavformat/id3v2.c | 2 +- > > libavformat/id3v2.h | 2 +- > > libavformat/mov_chan.c | 2 +- > > libavformat/movenc.c | 2 +- > > libavformat/mxfdec.c | 2 +- > > libavresample/audio_mix.c | 2 +- > > libavutil/hwcontext.c | 2 +- > > libavutil/hwcontext_vaapi.c | 2 +- > > libavutil/parseutils.c | 2 +- > > libavutil/pixdesc.c | 10 +++++----- > > libavutil/stereo3d.c | 2 +- > > 51 files changed, 129 insertions(+), 129 deletions(-) > > Does this add warnings?
Yes, avio_enum_protocols now has a warning about discarding qualifiers. I think the patch is still correct though, since the protocol table never changes (and must never change), so it should be const. > > How did you arrive at the list of tables to constify? IIRC they are placed in the .data section instead of .rodata. It's been a while since I wrote this. -- Anton Khirnov _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel