On Wed, Jan 11, 2017 at 10:16:55AM +0100, Anton Khirnov wrote:
> Quoting wm4 (2017-01-11 08:08:49)
> > On Tue, 10 Jan 2017 15:42:33 +0100
> > Anton Khirnov <[email protected]> wrote:
> > > --- a/doc/multithreading.txt
> > > +++ b/doc/multithreading.txt
> > > @@ -58,9 +58,10 @@ Add CODEC_CAP_FRAME_THREADS to the codec capabilities. 
> > > There will be very little
> > >  
> > >  If there are inter-frame dependencies, so the codec calls
> > > -ff_thread_report/await_progress(), set 
> > > AVCodecInternal.allocate_progress. The
> > > +ff_thread_report/await_progress(), set FF_CODEC_CAP_ALLOCATE_PROGRESS in
> > > +AVCodec.caps_internal and use ff_thread_get_buffer() to allocate frames. 
> > > The
> > 
> > The sentence doesn't look like proper English (both before and after
> > your change) - maybe that could be fixed too?
> 
> Why? It looks rather normal to me.

Umm, no :)

Here's the sentence with third person singular 's' and s/so/then/:

  If there are inter-frame dependencies, then the codec calls
  ff_thread_report/await_progress(), sets FF_CODEC_CAP_ALLOCATE_PROGRESS in
  AVCodec.caps_internal, and uses ff_thread_get_buffer() to allocate frames.

Probably s/calls/has to call/ would be even better.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to