Am 15.01.2017 5:45 AM schrieb "Luca Barbato" <[email protected]>:

On 14/01/2017 18:48, Devesh wrote:
> +    if (((*p->buf & 0xF0)>>4) == GSM_MAGIC_NUM)
> +        return AVPROBE_SCORE_MAX ;

Doesn't seem exactly robust maybe we could check a little more data or
rank it to a lower score


I agree, this is an extremely short signature to check, so it would likely
find more false positives then actual hits, considering how rare such files
are, in comparison to everything else.

A longer signature would be best, even low scores tend to screw things up
with such broad matches.

- Hendrik
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to