On Sun, 29 Jan 2017 23:54:45 +0200 (EET)
Martin Storsjö <[email protected]> wrote:

> > +    // re-open buffer
> > +    return avio_open_dyn_buf(&os->ctx->pb);
> > +}  
> 
> Sorry for not noticing in the previous round, but... If avio_open_dyn_buf 
> fails, it will not set the pointer to NULL, so in that case, we'd end up 
> with a dangling pointer in os->ctx->pb and end up with a double free 
> later.
> 
> The rest of the patch seems fine. No need to repost just for this, I can 
> add the necessary os->ctx->pb = NULL before pushing.

Go ahead fixing these little things and formating issues in the other patches.

Thanks for reviewing!

Regards
Peter

Attachment: pgpXIecOe8GzD.pgp
Description: OpenPGP digital signature

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to