On Sat, Feb 4, 2017 at 11:11 AM, Diego Biurrun <di...@biurrun.de> wrote:
> On Fri, Feb 03, 2017 at 05:57:33PM +0100, Vittorio Giovara wrote:
>> --- /dev/null
>> +++ b/libavcodec/pixlet.c
>> +static void postprocess_luma(AVFrame *frame, int w, int h, int depth)
>> +{
>> + uint16_t *dsty = (uint16_t *)frame->data[0];
>> + int16_t *srcy = (int16_t *)frame->data[0];
>
> pointless casts?
>
>> +static void postprocess_chroma(AVFrame *frame, int w, int h, int depth)
>> +{
>> + uint16_t *dstu = (uint16_t *)frame->data[1];
>> + uint16_t *dstv = (uint16_t *)frame->data[2];
>> + int16_t *srcu = (int16_t *)frame->data[1];
>> + int16_t *srcv = (int16_t *)frame->data[2];
>
> same?
>
>> +static int decode_plane(AVCodecContext *avctx, int plane,
>> + AVPacket *avpkt, AVFrame *frame)
>> + dst = (int16_t *) frame->data[plane];
>> + dst[0] = sign_extend(bytestream2_get_be16(&ctx->gb), 16);
>
> same?
All these casts are necessary because frame->data is uint8_t*.
Fixed all the other comments.
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
