On 02/18/2017 01:20 PM, Luca Barbato wrote: > On 18/02/2017 14:37, John Stebbins wrote: > >> I forgot this was still pending. I never got an answer to my last >> question above. Do you all think wm4's suggestion is sensible. His >> suggestion results in dv_read_packet returning 0 instead of EIO when >> avio_read returns 0. IMO, if this change results in other issues, >> those issues should be fixed since they rely on broken behaviour, so >> my opinion is wm4's suggestion is good. >> > There is a pb->eof_reached for it. > >
I'm not sure what you are getting at. avio_read will return AVERROR_EOF when EOF is reached and AVIOContext buffer has been consumed. So there is no need to look at pb->eof_reached in dv.c. In fact, I think it's not possible for avio_read to return 0. It looks like all scenarios that would result in 0 either generate an error or eof. -- John GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01 83F0 49F1 D7B2 60D4 D0F7
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
