On Mon, 20 Feb 2017, John Stebbins wrote:
On 02/20/2017 03:27 PM, Martin Storsjö wrote:
I'd appreciate if you could add a few cases in that test
(libavformat/tests/movenc.c) to validate all the different corner
cases that this code touches. This test writes synthetic test data in
different setups and hashes the results. By running it as
./libavformat/tests/movenc -w, it will write the actual output files
to disk. Since it's synthetic data (i.e. broken/fake packet payloads),
it's mostly interesting to look at the produced edit lists with
boxdumper or so.
I've been tripped up by a few corner cases while working on this. I
found yet another today that I'll need to modify this patch for one more
time (round-off error causing a 1ms shift in delay). I'll have a look
at the existing tests and see what can be added to improve coverage. It
would help if someone could resolve my problem with uploading to fate
samples. I mentioned this on IRC and I'm not the only one that has had
a problem with this. The wiki says that if you have commit access you
should automatically have fate upload privileges. But that doesn't seem
to be the case.
FWIW, the movenc unit test doesn't need/use any external samples or
reference files, but you should have access to the fate samples in any
case.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
