On 21/02/2017 23:43, Mark Thompson wrote: > On 21/02/17 14:21, wm4 wrote: >> On Tue, 21 Feb 2017 13:18:55 +0000 >> Mark Thompson <[email protected]> wrote: >> >>> On 21/02/17 08:00, wm4 wrote: >>>> On Mon, 20 Feb 2017 23:06:21 +0000 >>>> Mark Thompson <[email protected]> wrote: >>>> >>>>>>> +#ifdef CL_ABGR >>>>>>> + if (0) >>>>>> >>>>>> wut >>>>> >>>>> CL_ABGR didn't exist in OpenCL 1.2, which is really the target. It's >>>>> present in later versions, though, so it's included here if possible for >>>>> symmetry. >>>> >>>> I meant what do the "if (0)"s do here? They're highly confusing at >>>> best. >>> >>> Avoiding more gotos? This function should really be a table, but it's just >>> tricky enough to make that annoying. I'll see if I can improve it. >> >> Yeah, I think that would be better. Also you could say you're using >> switch-case as some sort of computed goto, which it really is, but ugly >> and hard to read. > > Right, taking this function to its (perhaps il)logical conclusion I can > replace it with: >
Looks cuter :) _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
