On 26/02/17 10:44, Nicolas George wrote:
> L'octidi 8 ventôse, an CCXXV, Mark Thompson a écrit :
>> The human-readable string does not have any meaning for users either -
>> what would you like them to conclude given the string "undefined
>> behaviour"?  (Instead of -16, the error in this case:
>> <https://github.com/lu-zero/mfx_dispatch/blob/master/mfx/mfxdefs.h#L116>.)
> 
> Some of them are: "invalid video parameters" for example.

And what would the user conclude from that message?  Have they done something 
incorrectly?  If so, what?  Or is it a bug in the filter?  All of these 
messages pretty much require reading the source code and looking at the 
documentation for the relevant libmfx function to determine what they mean.  
(Well, maybe not "out of memory".)

>> The error code is added to make it easier for a developer to work out
>> what went wrong from a log afterwards, and any interpretation of what
>> it means is always going to require reading the source code.
> 
> I think an error message or any other kind of information that is never
> of use to simple users does not belong in error messages above the
> "verbose" level.

I disagree.  For normal output, yes, this sort of thing is unhelpful.  For 
fatal error cases, precise information such as error codes should be provided 
so that someone reading the source code can determine exactly what the error 
was and where it happened.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to