Hi John,

On Feb 26, 2017 12:58, "John Stebbins" <[email protected]> wrote:

This patch set adds 2 enhancements to put_bits.  First bounds checking
the destination buffer to prevent invalid writes.  Second uint64_t
internal bit cache for a small, but measurable, performance increase
on 64bit systems.


This is not a review per se, but I must admit that it always bothered me
that this wasn't done before, but I always assumed it was
performance-sensitive since it is used almost everywhere.

I'm glad you discovered the opposite on some configurations. Are we sure it
doesn't cause performance regressions on other platforms though? Maybe
those that are register-starved?

-- Sean McG.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to