On Tue, Feb 28, 2017 at 1:52 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 28/02/2017 16:58, Vittorio Giovara wrote: >> Hi, >> this should be the final version of the set. A couple of these have >> been reviewed, but I would like to have a final complete pass before >> pushing. >> >> Cheers, >> Vittorio > > > Overall looks ok, between the two versions for setting the bounds I do > not have an opinion, pick the one you like better.
ok thank you Oracle caught a 32 bit truncating, I changed the relevant code in sherical.c - size_t orig_width = (size_t) width * UINT32_MAX / - (UINT32_MAX - map->bound_right - map->bound_left); - size_t orig_height = (size_t) height * UINT32_MAX / - (UINT32_MAX - map->bound_bottom - map->bound_top); + uint64_t orig_width = (uint64_t) width * UINT32_MAX / + (UINT32_MAX - map->bound_right - map->bound_left); + uint64_t orig_height = (uint64_t) height * UINT32_MAX / + (UINT32_MAX - map->bound_bottom - map->bound_top); -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
