On 15/03/2017 15:44, Diego Biurrun wrote:
> On Wed, Mar 15, 2017 at 01:40:03PM +0100, Luca Barbato wrote:
>> --- a/configure
>> +++ b/configure
>> @@ -4836,8 +4838,8 @@ check_header soundcard.h
>>  
>> -enabled jack_indev && check_lib jack jack/jack.h jack_client_open -ljack &&
>> -    check_func jack_port_get_latency_range -ljack
>> +enabled libjack && require_pkg_config libjack jack jack/jack.h 
>> jack_client_open &&
>> +    check_pkg_config libjack jack jack/jack.h jack_port_get_latency_range
> 
> This is redundant or wrong. check_pkg_config() will disable libjack again if
> jack_port_get_latency_range() is not available. 

They should be flipped first the check and then the other check if the
first failed.

> You probably want to keep the
> check_func() call as-is.

It wouldn't work. That's one of the reasons I started changing it. jack
is in a custom path and pkg-config finds it.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to