Is the below comment good enough at the start of the "if()" block? /* if provided, override the default const qp values */
If yes, I will add this line and send the modified patch. Thanks and regards, Konda Raju -----Original Message----- From: Luca Barbato [mailto:[email protected]] Sent: Friday, March 17, 2017 3:35 PM To: Konda Raju <[email protected]>; libav development <[email protected]> Cc: [email protected] Subject: Re: [libav-devel] [PATCH] nvenc: Allow different const qps for I, P and B frames On 17/03/2017 05:26, Konda Raju wrote: > Hi, > > Please review the attached patch. > > This patch allows to specify different const qp values for I, P and B frames. > This change is backward compatible. > Note that the constQP values are initialized with default values in preset > configuration, hence there is not "else()" block in set_constqp(). > Looks ok, but maybe it should be documented a little. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
