Hi Diego, On Fri, Mar 24, 2017 at 3:35 PM, Diego Biurrun <[email protected]> wrote: > On Fri, Mar 24, 2017 at 03:31:26PM -0400, Sean McGovern wrote: >> --- a/libavformat/nsvdec.c >> +++ b/libavformat/nsvdec.c >> @@ -571,7 +572,10 @@ null_chunk_retry: >> if (vsize && st[NSV_ST_VIDEO]) { >> nst = st[NSV_ST_VIDEO]->priv_data; >> pkt = &nsv->ahead[NSV_ST_VIDEO]; >> - av_get_packet(pb, pkt, vsize); >> + if ((ret = av_get_packet(pb, pkt, vsize)) < 0) { >> + av_log(s, AV_LOG_ERROR, "Invalid video packet size 0.\n"); >> + return ret; >> + } > > I liked the previous version better. Log messages for broken packets > seem pretty silly. Thoughts? > > Also the previous version did not contain tabs ;) > > Diego
Oops on the tabs -- I thought I had spaces/tabs disabled in Eclipse. Resubmit or is there consensus the first is OK? -- Sean McG. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
