On Fri, 31 Mar 2017, Diego Biurrun wrote:

---

ff_mov_get_lpcm_codec_id() is just a wrapper function, so I moved it
to a header as static inline. mov_esds.c is a proper name, so this is
no longer an RFC.

libavformat/Makefile   |  5 ++---
libavformat/internal.h | 14 ++++++++++++++
libavformat/isom.h     |  1 -
libavformat/mov.c      | 36 ------------------------------------
libavformat/mov_esds.c | 43 +++++++++++++++++++++++++++++++++++++++++++
5 files changed, 59 insertions(+), 40 deletions(-)
create mode 100644 libavformat/mov_esds.c

The esds part looks ok to me, I'm not sure if that function belongs in the lavf global internal.h - perhaps just keeping it in isom.h would be more straightforward?

In any case this seems better than the previous proposal.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to