Contrary to e.g. h264pred and h264qpel, all of these are within the
same HEVCDSPContext.
---
This IMO makes the checkasm output look less cluttered and more
consistent with the rest.
Before:
- h264dsp.idct [OK]
- h264pred.pred8x8 [OK]
- h264pred.pred16x16 [OK]
- h264qpel.put [OK]
- h264qpel.avg [OK]
- hevc_add_res.add_residual [OK]
- hevc_idct.idct_dc [OK]
- hevc_idct.idct [OK]
- vp8dsp.idct [OK]
- vp8dsp.mc [OK]
- vp8dsp.loopfilter [OK]
After:
- h264dsp.idct [OK]
- h264pred.pred8x8 [OK]
- h264pred.pred16x16 [OK]
- h264qpel.put [OK]
- h264qpel.avg [OK]
- hevcdsp.add_residual [OK]
- hevcdsp.idct_dc [OK]
- hevcdsp.idct [OK]
- vp8dsp.idct [OK]
- vp8dsp.mc [OK]
- vp8dsp.loopfilter [OK]
The downside obviously is that you can't run (or ignore) one individual of
these test groups but only all hevc at once, but I don't think that's too
much of an issue.
---
tests/checkasm/Makefile | 3 ++-
tests/checkasm/checkasm.c | 4 +---
tests/checkasm/checkasm.h | 1 +
tests/checkasm/hevcdsp.c | 26 ++++++++++++++++++++++++++
tests/fate/checkasm.mak | 4 +---
5 files changed, 31 insertions(+), 7 deletions(-)
create mode 100644 tests/checkasm/hevcdsp.c
diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile
index d5febec..c96003a 100644
--- a/tests/checkasm/Makefile
+++ b/tests/checkasm/Makefile
@@ -12,7 +12,8 @@ AVCODECOBJS-$(CONFIG_VP8DSP) += vp8dsp.o
# decoders/encoders
AVCODECOBJS-$(CONFIG_DCA_DECODER) += dcadsp.o synth_filter.o
-AVCODECOBJS-$(CONFIG_HEVC_DECODER) += hevc_add_res.o hevc_idct.o hevc_mc.o
+AVCODECOBJS-$(CONFIG_HEVC_DECODER) += hevcdsp.o hevc_add_res.o \
+ hevc_idct.o hevc_mc.o
AVCODECOBJS-$(CONFIG_V210_ENCODER) += v210enc.o
AVCODECOBJS-$(CONFIG_VP9_DECODER) += vp9dsp.o
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 61515de..6b10399 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -90,9 +90,7 @@ static const struct {
{ "h264qpel", checkasm_check_h264qpel },
#endif
#if CONFIG_HEVC_DECODER
- { "hevc_add_res", checkasm_check_hevc_add_res },
- { "hevc_idct", checkasm_check_hevc_idct },
- { "hevc_mc", checkasm_check_hevc_mc },
+ { "hevcdsp", checkasm_check_hevcdsp },
#endif
#if CONFIG_HUFFYUVDSP
{ "huffyuvdsp", checkasm_check_huffyuvdsp },
diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
index db71382..56aba4d 100644
--- a/tests/checkasm/checkasm.h
+++ b/tests/checkasm/checkasm.h
@@ -39,6 +39,7 @@ void checkasm_check_fmtconvert(void);
void checkasm_check_h264dsp(void);
void checkasm_check_h264pred(void);
void checkasm_check_h264qpel(void);
+void checkasm_check_hevcdsp(void);
void checkasm_check_hevc_add_res(void);
void checkasm_check_hevc_idct(void);
void checkasm_check_hevc_mc(void);
diff --git a/tests/checkasm/hevcdsp.c b/tests/checkasm/hevcdsp.c
new file mode 100644
index 0000000..73387f3
--- /dev/null
+++ b/tests/checkasm/hevcdsp.c
@@ -0,0 +1,26 @@
+/*
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * Libav is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with Libav; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#include "checkasm.h"
+
+void checkasm_check_hevcdsp(void)
+{
+ checkasm_check_hevc_add_res();
+ checkasm_check_hevc_idct();
+ checkasm_check_hevc_mc();
+}
diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak
index 5721f1f..f74e748 100644
--- a/tests/fate/checkasm.mak
+++ b/tests/fate/checkasm.mak
@@ -6,9 +6,7 @@ FATE_CHECKASM = fate-checkasm-audiodsp
\
fate-checkasm-h264dsp \
fate-checkasm-h264pred \
fate-checkasm-h264qpel \
- fate-checkasm-hevc_add_res \
- fate-checkasm-hevc_idct \
- fate-checkasm-hevc_mc \
+ fate-checkasm-hevcdsp \
fate-checkasm-huffyuvdsp \
fate-checkasm-synth_filter \
fate-checkasm-v210enc \
--
2.7.4
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel