On Thu, Apr 20, 2017 at 11:04:26PM +0300, Martin Storsjö wrote:
> On Thu, 20 Apr 2017, Alexandra Hájková wrote:
> >From: Seppo Tomperi <[email protected]>
> >--- a/libavcodec/arm/hevcdsp_init_arm.c
> >+++ b/libavcodec/arm/hevcdsp_init_arm.c
> >@@ -26,8 +26,12 @@
> >#include "libavcodec/hevcdsp.h"
> >
> >void ff_hevc_idct_4x4_8_neon(int16_t *coeffs, int col_limit);
> >+void ff_hevc_idct_4x4_dc_8_neon(int16_t *coeffs);
> >void ff_hevc_idct_8x8_8_neon(int16_t *coeffs, int col_limit);
> >+void ff_hevc_idct_8x8_dc_8_neon(int16_t *coeffs);
> >void ff_hevc_idct_16x16_8_neon(int16_t *coeffs, int col_limit);
> >+void ff_hevc_idct_16x16_dc_8_neon(int16_t *coeffs);
> >+void ff_hevc_idct_32x32_dc_8_neon(int16_t *coeffs);
> >void ff_hevc_idct_4x4_10_neon(int16_t *coeffs, int col_limit);
> >void ff_hevc_idct_8x8_10_neon(int16_t *coeffs, int col_limit);
> >void ff_hevc_idct_16x16_10_neon(int16_t *coeffs, int col_limit);
>
> As Diego suggested and I said in the previous review, group these with the
> idct_dc separately. You do this change in patch 2/2, but make it this way in
> the first commit directly instead of changing it later.
Yes, it's pointless churn to add the lines in 1/2 and move them in 2/2.
> >@@ -38,9 +42,14 @@ av_cold void ff_hevc_dsp_init_arm(HEVCDSPContext *c, int
> >bit_depth)
> >
> > if (have_neon(cpu_flags)) {
> > if (bit_depth == 8) {
> >- c->idct[0] = ff_hevc_idct_4x4_8_neon;
> >- c->idct[1] = ff_hevc_idct_8x8_8_neon;
> >- c->idct[2] = ff_hevc_idct_16x16_8_neon;
> >+ c->idct_dc[0] = ff_hevc_idct_4x4_dc_8_neon;
> >+ c->idct_dc[1] = ff_hevc_idct_8x8_dc_8_neon;
> >+ c->idct_dc[2] = ff_hevc_idct_16x16_dc_8_neon;
> >+ c->idct_dc[3] = ff_hevc_idct_32x32_dc_8_neon;
> >+
> >+ c->idct[0] = ff_hevc_idct_4x4_8_neon;
> >+ c->idct[1] = ff_hevc_idct_8x8_8_neon;
> >+ c->idct[2] = ff_hevc_idct_16x16_8_neon;
>
> I'm not sure if I feel that it's necessary to realign the idct lines here;
> since they're grouped separately we could just have them aligned separately
> as well. (I'm not sure if Diego agrees here or not.)
I'd just add the idct_dc lines below w/o touching the existing lines.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
