On Wed, Apr 26, 2017 at 11:38:17AM -0400, Vittorio Giovara wrote:
> request_channel_layout is a decoder option and it makes no sense
> to have it in a parser.
> 
> This feature was needed in the past when the decoder was allowed
> to reuse the avctx from the demuxer. Nowadays the decoder receives
> only the parameters from it, already containing the real channel
> layout (and the correct request_channel_layout option).
> 
> After initialization the decoder overwrites the channel layout
> with the downmixed one that is actually output, so there is no need
> to preserve this functionality in the parser.
> 
> Signed  Vittorio Giovara <[email protected]>
> 
> Signed-off-by: Vittorio Giovara <[email protected]>

Something went wrong with the s-o-b.

> --- a/libavcodec/aac_ac3_parser.c
> +++ b/libavcodec/aac_ac3_parser.c
> @@ -82,20 +82,8 @@ get_next:
>         seconds is still correct (as is the number of bits in the frame). */
>      if (avctx->codec_id != AV_CODEC_ID_AAC) {
>          avctx->sample_rate = s->sample_rate;
> +        avctx->channels = s->channels;
> +        avctx->channel_layout = s->channel_layout;

nit: align

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to