On Wed, Apr 26, 2017 at 02:52:28PM -0300, James Almer wrote: > On 4/26/2017 2:02 PM, Diego Biurrun wrote: > > This makes the currently semi-public avpriv_aac_parse_header() function > > private to libavcodec and adds a proper public API function to return > > the parts of the ADTS header required in libavformat. > > --- > > > > This eliminates one more ABI issue with the new bitstream reader. > > > > --- a/libavcodec/aacadtsdec.h > > +++ b/libavcodec/aacadtsdec.h > > This has become an adts parser header. Maybe the name should reflect > that, especially now that it will be installed. > It would be more in line with ac3_parser.h and vorbis_parser.h as well.
Good point. > > @@ -23,32 +23,19 @@ > > -int avpriv_aac_parse_header(GetBitContext *gbc, AACADTSHeaderInfo *hdr); > > +int av_aacadts_header_parse(const uint8_t *buf, uint32_t *samples, > > Why change it to _header_parse()? AC3's parse function was left as > _parse_header() when it was made public. Better keep it consistent. Because AFAIU it parses the ADTS header. That the function for the AC-3 header is inconsistently named is unfortunate. The rename should be in the other direction IMO. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
