On Wed, Apr 26, 2017 at 09:35:00PM +0200, Luca Barbato wrote: > On 4/26/17 8:36 PM, Diego Biurrun wrote: > > On Wed, Apr 26, 2017 at 12:35:17PM +0200, Diego Biurrun wrote: > >> On Wed, Apr 26, 2017 at 11:41:49AM +0200, Anton Khirnov wrote: > >>> @@ -118,19 +118,21 @@ static int vp9_superframe_filter(AVBSFContext *ctx, > >>> AVPacket *out) > >>> > >>> - profile = get_bits1(&gb); > >>> - profile |= get_bits1(&gb) << 1; > >>> + profile = bitstream_read(&bc, 1); > >>> + profile |= bitstream_read(&bc, 1) << 1; > >> > >> bitstream_read_bit() > > > > Or maybe we should drop bitstream_read_bit(), it's somewhat silly. > > As long bitstream_read is always inlined yes, it is redundant.
I think we just introduced it to translate the get_bits1 shorthand 1:1. It's not really shorter, so it's of doubtful utility. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
