On 5/19/2017 11:52 AM, Diego Biurrun wrote:
> On Fri, May 19, 2017 at 11:13:26AM -0300, James Almer wrote:
>> On 5/19/2017 10:47 AM, Anton Khirnov wrote:
>>> --- a/libavcodec/h264_sei.c
>>> +++ b/libavcodec/h264_sei.c
>>> @@ -54,21 +55,22 @@ void ff_h264_sei_uninit(H264SEIContext *h)
>>>
>>> -static int decode_picture_timing(H264SEIPictureTiming *h, GetBitContext
>>> *gb,
>>> - const SPS *sps, void *logctx)
>>> +int ff_h264_sei_process_picture_timing(H264SEIPictureTiming *h, const SPS
>>> *sps,
>>> + void *logctx)
>>> {
>>> - if (!sps)
>>> - return AVERROR_INVALIDDATA;
>>> + GetBitContext gb;
>>
>> GetBitContext gbc, *gb = &gbc;
>> init_get_bits(gb, h->payload, sizeof(h->payload));
>>
>> That way you don't have to replace all the lines below.
>
> Seems pointless IMO, replacing the variables does not hurt anything...
>
> Diego
Bigger patch that makes the change seem more complex than it really is
for no gain, affects git blame output, etc.
It's a nit anyway, so do as you prefer.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
